-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go version to 1.20.3 #2055
Update Go version to 1.20.3 #2055
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RamakrishnanArun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @RamakrishnanArun! |
go.mod
Outdated
k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a // indirect | ||
k8s.io/kube-state-metrics v1.9.8 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding v1 as a dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrueg Thanks for your review! I think this got added when I did a go mod tidy
and I didn't notice, my mistake. Let me remove this and push again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just need to remove that one line right? (k8s.io/kube-state-metrics v1.9.8 // indirect
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no, it got added when I ran go get k8s.io/kube-state-metrics
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved to a new PR because of user name and email issues with the commits.
Closing in favour of #2056 |
What this PR does / why we need it:
This PR upgrades the Go version to 1.20.3 which resolves a number of security vulnerabilities.
How does this change affect the cardinality of KSM: Does not change
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2054